sgdboop: init at 1.2.8 #341468
Open
sgdboop: init at 1.2.8 #341468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sikmir
reviewed
Sep 13, 2024
sikmir
reviewed
Sep 13, 2024
Saturn745
force-pushed
the
sgdboop-init
branch
from
1f79f8c
to
4614a2c
Compare
sikmir
reviewed
Sep 15, 2024
sikmir
reviewed
Sep 15, 2024
sikmir
reviewed
Sep 15, 2024
Comment on lines
+39
to
+44
| "cd" | ||
| "cdgl" | ||
| "cdcontextplus" |
There was a problem hiding this comment.
What about other targets:
do_all: cd cdpdf cdgl cdim cdcontextplus cdlua5 cdluapdf5 cdluagl5 cdluacontextplus5 cdluaim5There was a problem hiding this comment.
What about other targets:
do_all: cd cdpdf cdgl cdim cdcontextplus cdlua5 cdluapdf5 cdluagl5 cdluacontextplus5 cdluaim5
I figure that they weren't added originally because they weren't needed but I am not sure. Should I add those other targets?
sikmir
reviewed
Sep 15, 2024
sikmir
reviewed
Sep 15, 2024
sikmir
reviewed
Sep 15, 2024
sikmir
reviewed
Sep 15, 2024
sikmir
reviewed
Sep 15, 2024
Move to by-name Removed puffnfresh as a maintainer since the previous PR went stale and I am not sure if they still want to maintain this package. Rather be safe so they don't get mentioned if something with this does come up Rename to canvasdraw Co-authored-by: Saturn745 <[email protected]> Apply suggested changes
Move to by-name Remove puffnfresh as a maintainer and format Rename to imtoolkit Co-authored-by: Saturn745 <[email protected]> Apply suggested changes
Move to by-name Remove puffnfresh as a maintainer and format Update deps Co-authored-by: Saturn745 <[email protected]> Apply suggested changes
Move to by-name and update license Format Co-authored-by: Saturn745 <[email protected]> Apply suggested changes
Saturn745
force-pushed
the
sgdboop-init
branch
from
4614a2c
to
2a4a651
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This is a new PR based on @puffnfresh's original PR #269369, which went stale. I wasn't sure if I could do this or not, but I was told by a few people that I could so long as I kept Puffnfresh as a commiter, so I did. I also fixed trailing whitespace causing the editorconfig check to fail, updated the license for SGDBoop, and moved all of the packages to a
by-namestructure. One thing I was sure about was whether to keep Puffnfresh as a maintainer of these packages since his original PR went stale and nothing has been said from him. I did remove him from the maintainers of these, but I will add him back if he does want to maintain them.I apologize for any mistakes. I am still learning some things, and please let me know of any issues.
Closes: #269369, #220937
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.